-
Notifications
You must be signed in to change notification settings - Fork 43
Send notification meta checkbox #366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…be checked on refresh
My understanding was that the current behavior was what was always intended, i.e. so long as the "Send notification" setting is enabled from the admin page then the box should be enabled, even after refresh. Happy to be wrong on that but figured I'd at least double check. |
If I may share my opinion, at least based on our work at MacMagazine, it would be a disaster if the checkbox was enabled by default even on posts that are already published. We're a multi-person team and we constantly edit posts from each other to add new information, fix mistakes, etc. It would be a nightmare for us to always have to remember to uncheck that option. We only fire new pushes for previous posts when the edit is very relevant and we want to let our audience know that the post was edited. That's one of the reasons we're still on plugin version 2.4.4. It works exactly that way. |
@rfischmann That makes sense, thanks for the feedback! |
Hey guys, is there any ETA for a plugin update with this fix? Thanks! |
Hey @rfischmann, I'm just wrapping up a couple of other tasks before moving on to this. We will you keep you updated here with any changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM -- will move to merge and release
@rfischmann this is now released in https://github.com/OneSignal/OneSignal-WordPress-Plugin/releases/tag/v3.2.1 🚀 |
It seems fine now, @sherwinski, thanks! Just a small tweak for a future update: the checkbox still says "Send notification when post is published" when the post is already published. In that case, it should change to "Send notification when post is edited". Else, just show "Send notification when post is published/edited" in either case. |
Good call out @rfischmann -- I'll make an adjust to that in the next version. Thanks |
#348 visually unchecked the box on post, but a page refresh results in the checkbox being checked again.
This change is